Bug 37404 - new-run-webkit-tests shouldn't alter its path to import packages
Summary: new-run-webkit-tests shouldn't alter its path to import packages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-10 23:05 PDT by Adam Barth
Modified: 2010-04-10 23:55 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.59 KB, patch)
2010-04-10 23:06 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-10 23:05:52 PDT
new-run-webkit-tests shouldn't alter its path to import packages
Comment 1 Adam Barth 2010-04-10 23:06:22 PDT
Created attachment 53076 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-10 23:08:43 PDT
Comment on attachment 53076 [details]
Patch

Will this break running the script inside a Chromium checkout?
Comment 3 Eric Seidel (no email) 2010-04-10 23:09:39 PDT
Sorry for the CC spam.  Safari auto-completed a zillion people in the CC field and I didn't notice.
Comment 4 Eric Seidel (no email) 2010-04-10 23:10:06 PDT
Comment on attachment 53076 [details]
Patch

OK, but you get to watch the Chromium canary. :)
Comment 5 Adam Barth 2010-04-10 23:13:17 PDT
Comment on attachment 53076 [details]
Patch

Clearing flags on attachment: 53076

Committed r57443: <http://trac.webkit.org/changeset/57443>
Comment 6 Adam Barth 2010-04-10 23:13:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Barth 2010-04-10 23:49:23 PDT
> OK, but you get to watch the Chromium canary. :)

Looks like the Windows canary has an old version of Python.  Earlier today Marc-Antoine Ruel said he would upgrade the bot to 2.5.  I think the correct resolution here is to upgrade the bot.