Bug 37009 - The master commit-queue process should take responsibility for checking that the builders are green
Summary: The master commit-queue process should take responsibility for checking that ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 21:53 PDT by Adam Barth
Modified: 2010-04-02 01:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2010-04-01 21:53 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2010-04-01 22:17 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-01 21:53:09 PDT 
The master commit-queue process should take responsibility for checking that the builders are green
Comment 1 Adam Barth 2010-04-01 21:53:56 PDT 
Created attachment 52374 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-01 22:00:38 PDT 
Comment on attachment 52374 [details]
Patch

+                "--ignore-builders",

That change needs a comment to later developers that that's right, and remind them not to remove the builders_are_green check above! :)
Comment 3 Adam Barth 2010-04-01 22:17:31 PDT 
Created attachment 52376 [details]
Patch
Comment 4 Adam Barth 2010-04-02 01:18:54 PDT 
Comment on attachment 52376 [details]
Patch

Clearing flags on attachment: 52376

Committed r56986: <http://trac.webkit.org/changeset/56986>
Comment 5 Adam Barth 2010-04-02 01:18:59 PDT 
All reviewed patches have been landed.  Closing bug.