RESOLVED FIXED 36440
Make build_webkit_command() pass MAKEFLAGS environment variable to make 
https://bugs.webkit.org/show_bug.cgi?id=36440
Summary Make build_webkit_command() pass MAKEFLAGS environment variable to make
Csaba Osztrogonác
Reported 2010-03-22 04:50:17 PDT
Now build_webkit_command() doesn't pass MAKEFLAGS environtment variable to make. I propose this kind of modification: - command.append('--makeargs="-j%s"' % Executive.cpu_count()) + command.append(WebKitPort.makeArgs()) It is a useful feature if you would like to use more jobs than number of CPU cores. (for distcc jobs) I tested this patch, and works correctly on our Qt-EWS.
Attachments
proposed patch (4.07 KB, patch)
2010-03-22 04:51 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-03-22 04:51:41 PDT
Created attachment 51275 [details] proposed patch
Adam Barth
Comment 2 2010-03-22 10:41:10 PDT
Comment on attachment 51275 [details] proposed patch Ideally we would test that the environment var was respected, but this looks good.
WebKit Commit Bot
Comment 3 2010-03-22 18:13:30 PDT
Comment on attachment 51275 [details] proposed patch Clearing flags on attachment: 51275 Committed r56372: <http://trac.webkit.org/changeset/56372>
WebKit Commit Bot
Comment 4 2010-03-22 18:13:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.