Bug 36440 - Make build_webkit_command() pass MAKEFLAGS environment variable to make
Summary: Make build_webkit_command() pass MAKEFLAGS environment variable to make
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-22 04:50 PDT by Csaba Osztrogonác
Modified: 2010-03-22 18:13 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (4.07 KB, patch)
2010-03-22 04:51 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-03-22 04:50:17 PDT 
Now build_webkit_command() doesn't pass MAKEFLAGS 
environtment variable to make. 

I propose this kind of modification:
-        command.append('--makeargs="-j%s"' % Executive.cpu_count())
+        command.append(WebKitPort.makeArgs())

It is a useful feature if you would like to use more
jobs than number of CPU cores. (for distcc jobs)

I tested this patch, and works correctly on our Qt-EWS.
Comment 1 Csaba Osztrogonác 2010-03-22 04:51:41 PDT 
Created attachment 51275 [details]
proposed patch
Comment 2 Adam Barth 2010-03-22 10:41:10 PDT 
Comment on attachment 51275 [details]
proposed patch

Ideally we would test that the environment var was respected, but this looks good.
Comment 3 WebKit Commit Bot 2010-03-22 18:13:30 PDT 
Comment on attachment 51275 [details]
proposed patch

Clearing flags on attachment: 51275

Committed r56372: <http://trac.webkit.org/changeset/56372>
Comment 4 WebKit Commit Bot 2010-03-22 18:13:35 PDT 
All reviewed patches have been landed.  Closing bug.