WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
36264
Teach what-broke how to look up reviewer and author Committer objects by name
https://bugs.webkit.org/show_bug.cgi?id=36264
Summary
Teach what-broke how to look up reviewer and author Committer objects by name
Eric Seidel (no email)
Reported
2010-03-17 19:18:51 PDT
Teach what-broke how to look up reviewer and author Committer objects by name
Attachments
Patch
(4.90 KB, patch)
2010-03-17 19:20 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-03-17 19:20:43 PDT
Created
attachment 50993
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-03-17 19:22:19 PDT
It is clear to me now that we need a CommitInfo object to encapsulate all this logic. I will add one tomorrow.
Adam Barth
Comment 3
2010-03-17 22:46:56 PDT
Comment on
attachment 50993
[details]
Patch Ok. We'll need to add the SVN email address to committers.py if we don't have that there already.
Eric Seidel (no email)
Comment 4
2010-03-17 22:47:49 PDT
All emails are there for all committers. Or should be. The first email in the list is assumed to be the bugzilla email address.
WebKit Commit Bot
Comment 5
2010-03-18 05:47:07 PDT
Comment on
attachment 50993
[details]
Patch Clearing flags on attachment: 50993 Committed
r56156
: <
http://trac.webkit.org/changeset/56156
>
WebKit Commit Bot
Comment 6
2010-03-18 05:47:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug