Bug 36264 - Teach what-broke how to look up reviewer and author Committer objects by name
Summary: Teach what-broke how to look up reviewer and author Committer objects by name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-17 19:18 PDT by Eric Seidel (no email)
Modified: 2010-03-18 05:47 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2010-03-17 19:20 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-03-17 19:18:51 PDT 
Teach what-broke how to look up reviewer and author Committer objects by name
Comment 1 Eric Seidel (no email) 2010-03-17 19:20:43 PDT 
Created attachment 50993 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-17 19:22:19 PDT 
It is clear to me now that we need a CommitInfo object to encapsulate all this logic.  I will add one tomorrow.
Comment 3 Adam Barth 2010-03-17 22:46:56 PDT 
Comment on attachment 50993 [details]
Patch

Ok.  We'll need to add the SVN email address to committers.py if we don't have that there already.
Comment 4 Eric Seidel (no email) 2010-03-17 22:47:49 PDT 
All emails are there for all committers.  Or should be.  The first email in the list is assumed to be the bugzilla email address.
Comment 5 WebKit Commit Bot 2010-03-18 05:47:07 PDT 
Comment on attachment 50993 [details]
Patch

Clearing flags on attachment: 50993

Committed r56156: <http://trac.webkit.org/changeset/56156>
Comment 6 WebKit Commit Bot 2010-03-18 05:47:12 PDT 
All reviewed patches have been landed.  Closing bug.