Bug 36004 - Enhance Qt DRT implementation to support platform scroll wheel events.
Summary: Enhance Qt DRT implementation to support platform scroll wheel events.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-03-10 21:59 PST by Andy Estes
Modified: 2010-11-25 11:13 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.15 KB, patch)
2010-05-30 08:15 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2010-03-10 21:59:30 PST
DRT layout tests gained the ability to simulate mouse scroll wheel events in http://trac.webkit.org/changeset/55739.  Currently this is only supported on Mac OS 10.5 and 10.6.  The Qt DRT implementation should be enhanced to dispatch scroll wheel events, and layout tests that utilize this functionality should be removed from the Skipped file.
Comment 1 Tor Arne Vestbø 2010-03-22 06:36:57 PDT
Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs
Comment 2 Robert Hogan 2010-05-30 08:15:10 PDT
Created attachment 57419 [details]
Patch
Comment 3 Kenneth Rohde Christiansen 2010-05-30 08:23:13 PDT
Comment on attachment 57419 [details]
Patch

LGTM, thought it would have been nice if the QWheelEvent could send for both axises.

Great work Robert!
Comment 4 WebKit Commit Bot 2010-05-30 10:53:15 PDT
Comment on attachment 57419 [details]
Patch

Clearing flags on attachment: 57419

Committed r60415: <http://trac.webkit.org/changeset/60415>
Comment 5 WebKit Commit Bot 2010-05-30 10:53:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Robert Hogan 2010-06-10 14:47:59 PDT
Need to watch developments at https://bugs.webkit.org/show_bug.cgi?id=40441 , as we were shadowing the changes there.
Comment 7 Robert Hogan 2010-06-10 14:48:30 PDT
(In reply to comment #6)
> Need to watch developments at https://bugs.webkit.org/show_bug.cgi?id=40441 , as we were shadowing the changes *reverted* there.
Comment 8 Robert Hogan 2010-06-10 14:50:06 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > Need to watch developments at https://bugs.webkit.org/show_bug.cgi?id=40441 , as we were shadowing the changes *reverted* there.

Actually, need to follow developments at https://bugs.webkit.org/show_bug.cgi?id=29601.
Comment 9 Benjamin Poulain 2010-11-19 04:38:39 PST
(In reply to comment #8)
> Actually, need to follow developments at https://bugs.webkit.org/show_bug.cgi?id=29601.

Robert, shouldn't this bug be closed? It looks like the task "Enhance Qt DRT implementation to support platform scroll wheel events." is done.
Comment 10 Robert Hogan 2010-11-25 11:13:38 PST
(In reply to comment #9)
> (In reply to comment #8)
> > Actually, need to follow developments at https://bugs.webkit.org/show_bug.cgi?id=29601.
> 
> Robert, shouldn't this bug be closed? It looks like the task "Enhance Qt DRT implementation to support platform scroll wheel events." is done.

OK, will close it.