Bug 35955 - [Qt] Non animated gifs are animated in QtWebKit
Summary: [Qt] Non animated gifs are animated in QtWebKit
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-10 00:09 PST by Holger Freyther
Modified: 2010-03-10 02:46 PST (History)
1 user (show)

See Also:

Make non-animated gifs' non-animated. (7.59 KB, patch)
2010-03-10 00:15 PST, Holger Freyther
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2010-03-10 00:09:00 PST
The QImageReader::loopCount was wrong until recently for non animated gifs but that was fixed in Qt4.7. We will need the loopCount of Qt to WebCore.
Comment 1 Holger Freyther 2010-03-10 00:15:06 PST
Created attachment 50374 [details]
Make non-animated gifs' non-animated.

First attempt...
Comment 2 WebKit Review Bot 2010-03-10 00:16:32 PST
Attachment 50374 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/qt/ImageDecoderQt.cpp:130:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Holger Freyther 2010-03-10 02:46:39 PST
Landed in r55774.