RESOLVED FIXED 35955
[Qt] Non animated gifs are animated in QtWebKit 
https://bugs.webkit.org/show_bug.cgi?id=35955
Summary [Qt] Non animated gifs are animated in QtWebKit
Holger Freyther
Reported 2010-03-10 00:09:00 PST
The QImageReader::loopCount was wrong until recently for non animated gifs but that was fixed in Qt4.7. We will need the loopCount of Qt to WebCore.
Attachments
Make non-animated gifs' non-animated. (7.59 KB, patch)
2010-03-10 00:15 PST, Holger Freyther 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2010-03-10 00:15:06 PST
Created attachment 50374 [details] Make non-animated gifs' non-animated. First attempt...
WebKit Review Bot
Comment 2 2010-03-10 00:16:32 PST
Attachment 50374 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/qt/ImageDecoderQt.cpp:130: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Holger Freyther
Comment 3 2010-03-10 02:46:39 PST
Landed in r55774.
Note You need to log in before you can comment on or make changes to this bug.