Bug 35951 - Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80
Summary: Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 17:18 PST by Alexey Proskuryakov
Modified: 2010-03-09 20:08 PST (History)
1 user (show)

See Also:


Attachments
proposed fix (1.70 KB, patch)
2010-03-09 17:22 PST, Alexey Proskuryakov
oliver: review+
Details | Formatted Diff | Diff
Tiger fix (1.42 KB, patch)
2010-03-09 19:06 PST, Alexey Proskuryakov
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-03-09 17:18:25 PST
Dashcode crashes with ToT WebKit on many operations. Patch forthcoming.
Comment 1 Alexey Proskuryakov 2010-03-09 17:22:06 PST
Created attachment 50361 [details]
proposed fix
Comment 2 Oliver Hunt 2010-03-09 17:27:36 PST
Comment on attachment 50361 [details]
proposed fix

r=me
Comment 3 Alexey Proskuryakov 2010-03-09 17:29:58 PST
Committed <http://trac.webkit.org/changeset/55757>.
Comment 4 Alexey Proskuryakov 2010-03-09 18:58:43 PST
Need to fix Tiger code path, too.

Note that it's correct to use value personality in DOMInternal.mm - it's used for values there, and it just gives a description function.
Comment 5 Alexey Proskuryakov 2010-03-09 19:06:21 PST
Created attachment 50366 [details]
Tiger fix
Comment 6 Alexey Proskuryakov 2010-03-09 20:08:24 PST
Committed <http://trac.webkit.org/changeset/55760>.