Bug 35913 - [EFL] Add ChromeClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.
Summary: [EFL] Add ChromeClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 06:15 PST by Leandro Pereira
Modified: 2010-03-10 15:19 PST (History)
10 users (show)

See Also:

Attachments
Add ChromeClientEfl to WK/efl/WebCoreSupport. (15.67 KB, patch)
2010-03-09 06:15 PST, Leandro Pereira 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-03-09 06:15:08 PST 
+++ This bug was initially created as a clone of Bug #35059 +++

Attached patch adds EFL's implementation of ChromeClient to WebKit/efl/WebCoreSupport.
Comment 1 Leandro Pereira 2010-03-09 06:15:53 PST 
Created attachment 50296 [details]
Add ChromeClientEfl to WK/efl/WebCoreSupport.
Comment 2 Holger Freyther 2010-03-09 21:05:45 PST 
Comment on attachment 50296 [details]
Add ChromeClientEfl to WK/efl/WebCoreSupport.


> +    explicit ChromeClientEfl(Evas_Object *view);

style violation uncaught by the style bot... and the same for the Evas_Object* m_view. Please create a follow up patch.
Comment 3 WebKit Commit Bot 2010-03-10 15:19:25 PST 
Comment on attachment 50296 [details]
Add ChromeClientEfl to WK/efl/WebCoreSupport.

Clearing flags on attachment: 50296

Committed r55812: <http://trac.webkit.org/changeset/55812>
Comment 4 WebKit Commit Bot 2010-03-10 15:19:30 PST 
All reviewed patches have been landed.  Closing bug.