Compilation breaks if using GCC Flags: -pedantic -Wno-long-long in my Application Projects
I don't think "-pedantic" is supported. And this is not a QtWebKit problem, it seems JavascriptCore does not compile either with -pedantic.
I think it is. Again - my attached Patch from first Report? [code] --- src/3rdparty/webkit/WebKit/qt/Api/qwebelement.h.orig 2010-02-11 09:25:10.000000000 +0100 +++ src/3rdparty/webkit/WebKit/qt/Api/qwebelement.h 2010-02-11 09:26:04.000000000 +0100 @@ -136,5 +136,5 @@ InlineStyle, CascadedStyle, - ComputedStyle, + ComputedStyle }; QString styleProperty(const QString& name, StyleResolveStrategy strategy) const; [/code]
(In reply to comment #2) > I think it is. > Again - my attached Patch from first Report? > [code] > --- src/3rdparty/webkit/WebKit/qt/Api/qwebelement.h.orig 2010-02-11 > 09:25:10.000000000 +0100 > +++ src/3rdparty/webkit/WebKit/qt/Api/qwebelement.h 2010-02-11 > 09:26:04.000000000 +0100 > @@ -136,5 +136,5 @@ > InlineStyle, > CascadedStyle, > - ComputedStyle, > + ComputedStyle > }; > QString styleProperty(const QString& name, StyleResolveStrategy strategy) > const; > [/code] does this change make -pendantic builds to work for you ? if so I think it is not a problem to accept. please provide a patch w/ a change log entry. for that run WebKitTools/Scripts/prepare-Changelog --bug 35515 ... and add details to the entry.
Yep, definitely no problem with this patch. Do not hesitate to submit it as an attachement (some info: http://trac.webkit.org/wiki/QtWebKitContrib ) You need to provide a changelog by running WebKitTools/Script/prepare-changelog --bug 35515. When you attach the patch, set the review and commit-queue flag to "?".