Bug 35352 - [Qt] QtLauncher has a border when running on QGraphicsView mode
Summary: [Qt] QtLauncher has a border when running on QGraphicsView mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-24 11:33 PST by Jesus Sanchez-Palencia
Modified: 2010-02-24 21:08 PST (History)
2 users (show)

See Also:

Attachments
Remove frame border (1.81 KB, patch)
2010-02-24 11:43 PST, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2010-02-24 11:33:22 PST 
QtLauncher has a frame of 2 pixels when running on QGraphicsView mode. This should be removed.
Patch is coming.
Comment 1 Jesus Sanchez-Palencia 2010-02-24 11:43:16 PST 
Created attachment 49417 [details]
Remove frame border
Comment 2 WebKit Commit Bot 2010-02-24 11:46:45 PST 
Comment on attachment 49417 [details]
Remove frame border

Rejecting patch 49417 from review queue.

jesus.palencia@openbossa.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 3 Kenneth Rohde Christiansen 2010-02-24 11:48:58 PST 
Hmm, you are not supposed to set r+ but r? The patch looks good though.
Comment 4 Jesus Sanchez-Palencia 2010-02-24 11:50:51 PST 
Sorry for the confusion... It should be r? and cq?.
Comment 5 WebKit Commit Bot 2010-02-24 21:08:00 PST 
Comment on attachment 49417 [details]
Remove frame border

Clearing flags on attachment: 49417

Committed r55218: <http://trac.webkit.org/changeset/55218>
Comment 6 WebKit Commit Bot 2010-02-24 21:08:04 PST 
All reviewed patches have been landed.  Closing bug.