Bug 35023 - Missing property warning after r54873
Summary: Missing property warning after r54873
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 01:45 PST by Philippe Normand
Modified: 2010-02-17 02:49 PST (History)
1 user (show)

See Also:


Attachments
proposed patch (4.91 KB, patch)
2010-02-17 02:16 PST, Philippe Normand
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-02-17 01:45:52 PST
http://trac.webkit.org/changeset/54873#file10 introduces a new enable-file-access-from-file-uris property but it wasn't declared in the class.
Comment 1 Philippe Normand 2010-02-17 02:16:40 PST
Created attachment 48874 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-02-17 02:18:52 PST
Attachment 48874 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:1129:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xan Lopez 2010-02-17 02:38:27 PST
Comment on attachment 48874 [details]
proposed patch

r=me with a couple of issues fixed we commented on jabber.
Comment 4 Philippe Normand 2010-02-17 02:49:36 PST
Landed in r54882, thanks :)