Bug 35018 - [GTK] WebKitDownload documentation is incomplete
Summary: [GTK] WebKitDownload documentation is incomplete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 20:28 PST by Diego Escalante Urrelo
Modified: 2010-02-18 06:27 PST (History)
1 user (show)

See Also:


Attachments
2010-02-16 Diego Escalante Urrelo <descalante@igalia.com> (3.79 KB, patch)
2010-02-16 20:32 PST, Diego Escalante Urrelo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Escalante Urrelo 2010-02-16 20:28:29 PST
Patch follows.
Comment 1 Diego Escalante Urrelo 2010-02-16 20:32:07 PST
Created attachment 48859 [details]
2010-02-16  Diego Escalante Urrelo  <descalante@igalia.com>

Reviewed by NOBODY (OOPS!).

        [GTK] WebKitDownload documentation is incomplete
        https://bugs.webkit.org/show_bug.cgi?id=35018

        Concretely the error signal was undocumented. Also two relevant enums
        were not included.

        * docs/webkitgtk-sections.txt:
        * docs/webkitgtk.types:
        * webkit/webkitdownload.cpp:
        (webkit_download_class_init):
Comment 2 Gustavo Noronha (kov) 2010-02-18 06:08:00 PST
Comment on attachment 48859 [details]
2010-02-16  Diego Escalante Urrelo  <descalante@igalia.com>

229229      * WebKitDownload::error:
230230      * @download: the object on which the signal is emitted
231       * @current_bytes: the current count of bytes downloaded
232       * @total_bytes: the total bytes count in the downloaded file, aka file size.

That rocks lol =)
Comment 3 WebKit Commit Bot 2010-02-18 06:27:24 PST
Comment on attachment 48859 [details]
2010-02-16  Diego Escalante Urrelo  <descalante@igalia.com>

Clearing flags on attachment: 48859

Committed r54959: <http://trac.webkit.org/changeset/54959>
Comment 4 WebKit Commit Bot 2010-02-18 06:27:28 PST
All reviewed patches have been landed.  Closing bug.