Bug 34987 - [Android] V8 bindings are missing CHROMIUM and XPATH guards
Summary: [Android] V8 bindings are missing CHROMIUM and XPATH guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 13:37 PST by Steve Block
Modified: 2010-02-17 02:21 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.59 KB, patch)
2010-02-16 13:39 PST, Steve Block
no flags Details | Formatted Diff | Diff
Patch (4.59 KB, patch)
2010-02-16 15:28 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-16 13:37:06 PST
V8 bindings are missing CHROMIUM and XPATH guards.
This prevents building on Android, where Chromium-specific features are absent and XPATH is not enabled.
Comment 1 Steve Block 2010-02-16 13:39:20 PST
Created attachment 48823 [details]
Patch
Comment 2 WebKit Review Bot 2010-02-16 13:56:05 PST
Attachment 48823 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/270508
Comment 3 Steve Block 2010-02-16 14:37:06 PST
(In reply to comment #2)
> Attachment 48823 [details] did not build on chromium:
> Build output: http://webkit-commit-queue.appspot.com/results/270508
This appears to be unrelated to my change - I guess because the Mac-Chromium build is currently broken
Comment 4 Steve Block 2010-02-16 15:28:21 PST
Created attachment 48842 [details]
Patch
Comment 5 Ariya Hidayat 2010-02-16 15:43:34 PST
Comment on attachment 48842 [details]
Patch

LGTM.
Comment 6 Adam Barth 2010-02-16 18:04:08 PST
> This appears to be unrelated to my change - I guess because the Mac-Chromium
> build is currently broken

Strange.  The system is supposed to be robust to that.  I keep an eye out for another instance.
Comment 7 WebKit Commit Bot 2010-02-17 02:21:33 PST
Comment on attachment 48842 [details]
Patch

Clearing flags on attachment: 48842

Committed r54881: <http://trac.webkit.org/changeset/54881>
Comment 8 WebKit Commit Bot 2010-02-17 02:21:38 PST
All reviewed patches have been landed.  Closing bug.