V8 bindings are missing CHROMIUM and XPATH guards. This prevents building on Android, where Chromium-specific features are absent and XPATH is not enabled.
Created attachment 48823 [details] Patch
Attachment 48823 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/270508
(In reply to comment #2) > Attachment 48823 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/270508 This appears to be unrelated to my change - I guess because the Mac-Chromium build is currently broken
Created attachment 48842 [details] Patch
Comment on attachment 48842 [details] Patch LGTM.
> This appears to be unrelated to my change - I guess because the Mac-Chromium > build is currently broken Strange. The system is supposed to be robust to that. I keep an eye out for another instance.
Comment on attachment 48842 [details] Patch Clearing flags on attachment: 48842 Committed r54881: <http://trac.webkit.org/changeset/54881>
All reviewed patches have been landed. Closing bug.