Bug 34986 - re-factor Skipped list parsing code into multiple functions and unit test it
Summary: re-factor Skipped list parsing code into multiple functions and unit test it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2010-02-16 13:34 PST by Eric Seidel (no email)
Modified: 2010-02-16 14:21 PST (History)
0 users

See Also:


Attachments
Patch (10.71 KB, patch)
2010-02-16 13:54 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (10.94 KB, patch)
2010-02-16 14:01 PST, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-02-16 13:34:23 PST
re-factor Skipped list parsing code into multiple functions and unit test it
Comment 1 Eric Seidel (no email) 2010-02-16 13:54:49 PST
Created attachment 48826 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-02-16 14:01:40 PST
Created attachment 48828 [details]
Patch
Comment 3 Adam Barth 2010-02-16 14:08:59 PST
Comment on attachment 48828 [details]
Patch

Ok.  We need to unify our Port concept.
Comment 4 Eric Seidel (no email) 2010-02-16 14:21:52 PST
Committed r54830: <http://trac.webkit.org/changeset/54830>