Bug 34929 - [GTK] Glib unicode backend causing webkit to freeze during text editing
Summary: [GTK] Glib unicode backend causing webkit to freeze during text editing
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-14 08:56 PST by Alexander Butenko
Modified: 2014-04-08 16:08 PDT (History)
4 users (show)

See Also:


Attachments
patch (965 bytes, patch)
2010-02-14 08:56 PST, Alexander Butenko
no flags Details | Formatted Diff | Diff
patch with a cnp fix in changelog (883 bytes, patch)
2010-02-14 08:59 PST, Alexander Butenko
no flags Details | Formatted Diff | Diff
one more problem in changelog (917 bytes, patch)
2010-02-14 09:15 PST, Alexander Butenko
gustavo: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Butenko 2010-02-14 08:56:53 PST
Created attachment 48724 [details]
patch

fix was partly explained in https://bugs.webkit.org/show_bug.cgi?id=15914#c58
comment from Kalle Vahlman

Hovewer returning TextBreakDone instead of textBreakFirst was leading to a
freeze on new lines.

Attached patch fixing problem for me.
Comment 1 Alexander Butenko 2010-02-14 08:59:33 PST
Created attachment 48725 [details]
patch with a cnp fix in changelog
Comment 2 Alexander Butenko 2010-02-14 09:15:56 PST
Created attachment 48726 [details]
one more problem in changelog
Comment 3 Eric Seidel (no email) 2010-02-17 16:25:53 PST
Comment on attachment 48726 [details]
one more problem in changelog

Can we test this via a layout test?

The Gtk port also has unit tests, but layout tests would be preferred.

Something with a simple <input> field which used eventSender to do some input?

Here are some extra docs:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree
http://webkit.org/quality/testwriting.html
Comment 4 Alexander Butenko 2010-02-17 17:17:29 PST
glib unicode is not a default backend for webkit-gtk, so that seems will be tricky to test.
Comment 5 Gustavo Noronha (kov) 2010-03-11 14:58:08 PST
Comment on attachment 48726 [details]
one more problem in changelog

This fix doesn't look right. Why is UBRK_CHARACTER special here? Isn't returning TextBreakDone, simply exposing a different bug, maybe? Also, the ChangeLog needs some reasoning for the change, not just the boilerplate.
Comment 6 Martin Robinson 2010-10-20 20:51:31 PDT
CCing Carlos Garcia Campos, who knows quite a bit about the GLib unicode backend.
Comment 7 Martin Robinson 2014-04-08 16:08:55 PDT
We have removed the Glib unicode backend.