Bug 34926 - Web Inspector: XPathResult objects are not expanded in console.
Summary: Web Inspector: XPathResult objects are not expanded in console.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-14 05:21 PST by Pavel Feldman
Modified: 2010-02-15 02:21 PST (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed fix. (12.17 KB, patch)
2010-02-14 05:26 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-02-14 05:21:17 PST
You can see "Error dispatching: getProperties" in console upon value "expand" attempt instead.

I'd like to commit couple of drive-by fixes with this:
1) Use Object.getOwnPropertyNames in getProperties (as already used in completion)
2) Artificially append __proto__ property in case getting only own properties in order to allow further values browsing.
Comment 1 Pavel Feldman 2010-02-14 05:26:55 PST
Created attachment 48719 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2010-02-15 02:21:05 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/console-dir-expected.txt
	M	LayoutTests/inspector/console-dir.html
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/ObjectPropertiesSection.js
	M	WebCore/inspector/front-end/Section.js
	M	WebCore/inspector/front-end/inspector.css
Committed r54769