Bug 34916 - Four textcontrol tests fail after http://trac.webkit.org/changeset/54748
Summary: Four textcontrol tests fail after http://trac.webkit.org/changeset/54748
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-12 19:55 PST by Ojan Vafai
Modified: 2010-02-12 20:43 PST (History)
0 users

See Also:


Attachments
Patch (22.40 KB, patch)
2010-02-12 20:03 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (23.94 KB, patch)
2010-02-12 20:11 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (33.68 KB, patch)
2010-02-12 20:28 PST, Ojan Vafai
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-02-12 19:55:41 PST
transforms/3d/general/perspective-non-layer.html and fast/forms/text-control-intrinsic-widths.html

This is after http://trac.webkit.org/changeset/54748. I don't have access to a snow leopard machine at the moment. I'll check in the current results to green the bots and I'll figure out what's wrong next week when I can run it on snowleopard.
Comment 1 Ojan Vafai 2010-02-12 20:03:03 PST
Created attachment 48692 [details]
Patch
Comment 2 Ojan Vafai 2010-02-12 20:11:53 PST
Created attachment 48694 [details]
Patch
Comment 3 Ojan Vafai 2010-02-12 20:24:15 PST
Comment on attachment 48694 [details]
Patch

Turns out there are two windows tests failing as well that are my goofups with the expected files. I'll post a patch for all of them.
Comment 4 Ojan Vafai 2010-02-12 20:28:18 PST
Created attachment 48695 [details]
Patch
Comment 5 Maciej Stachowiak 2010-02-12 20:40:53 PST
Comment on attachment 48695 [details]
Patch

r=me
Comment 6 Ojan Vafai 2010-02-12 20:43:18 PST
Committed r54749: <http://trac.webkit.org/changeset/54749>