Bug 34831 - SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker
Summary: SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 00:09 PST by MORITA Hajime
Modified: 2010-02-15 18:36 PST (History)
3 users (show)

See Also:


Attachments
patch v0 (12.15 KB, patch)
2010-02-11 01:06 PST, MORITA Hajime
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MORITA Hajime 2010-02-11 00:09:47 PST
Eliminate following callbacks from SVGTextChunkWalker and fold them into primary callback
- setupBackground
- setupFill
- setupFillSelection
- setupStroke
- setupStrokeSelection
- setupForeground
Comment 1 MORITA Hajime 2010-02-11 01:06:07 PST
Created attachment 48550 [details]
patch v0
Comment 2 Nikolas Zimmermann 2010-02-15 17:30:49 PST
Comment on attachment 48550 [details]
patch v0

Looks great. r=me.
Comment 3 WebKit Commit Bot 2010-02-15 18:36:44 PST
Comment on attachment 48550 [details]
patch v0

Clearing flags on attachment: 48550

Committed r54806: <http://trac.webkit.org/changeset/54806>
Comment 4 WebKit Commit Bot 2010-02-15 18:36:51 PST
All reviewed patches have been landed.  Closing bug.