Bug 34709 - [WinCairo] Properly Handle Header in Plugin Print Positioning
Summary: [WinCairo] Properly Handle Header in Plugin Print Positioning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-08 10:01 PST by Brent Fulgham
Modified: 2010-02-08 10:30 PST (History)
0 users

See Also:

Attachments
Account for header height in Cairo *and* GDI contexts (1.77 KB, patch)
2010-02-08 10:09 PST, Brent Fulgham 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2010-02-08 10:01:11 PST 
Correct WinCairo plugin print positioning to account for header size.  Existing code ignored this, causing plugins to overlay other elements.
Comment 1 Brent Fulgham 2010-02-08 10:09:02 PST 
Created attachment 48340 [details]
Account for header height in Cairo *and* GDI contexts

Header height must be incorporated into the GDI World Transform so that plugins are positioned properly in print output.
Comment 2 Adam Roben (:aroben) 2010-02-08 10:11:16 PST 
Comment on attachment 48340 [details]
Account for header height in Cairo *and* GDI contexts

r=me
Comment 3 Brent Fulgham 2010-02-08 10:30:34 PST 
Landed in http://trac.webkit.org/changeset/54494.