Bug 34503 - Copyright year updating for Windows version resources should be automatic
Summary: Copyright year updating for Windows version resources should be automatic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 14:53 PST by Steve Falkenburg
Modified: 2010-02-02 16:26 PST (History)
0 users

See Also:


Attachments
Patch (5.23 KB, patch)
2010-02-02 15:00 PST, Steve Falkenburg
no flags Details | Formatted Diff | Diff
Patch (5.84 KB, patch)
2010-02-02 15:50 PST, Steve Falkenburg
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-02-02 14:53:41 PST
Copyright year updating for Windows version resources should be automatic
Comment 1 Steve Falkenburg 2010-02-02 15:00:12 PST
Created attachment 47975 [details]
Patch
Comment 2 Darin Adler 2010-02-02 15:08:27 PST
Comment on attachment 47975 [details]
Patch

Seems fine as long as we never build something in a different year than we release it. Or on a computer with a incorrectly set clock.
Comment 3 Steve Falkenburg 2010-02-02 15:50:28 PST
Created attachment 47979 [details]
Patch
Comment 4 Steve Falkenburg 2010-02-02 15:51:02 PST
Updated to pull year from a static file instead.
Comment 5 Darin Adler 2010-02-02 15:53:51 PST
Comment on attachment 47979 [details]
Patch

> +chomp COPYRIGHT_END_YEAR

Does this really exist?

r=me assuming it all works
Comment 6 Steve Falkenburg 2010-02-02 16:26:27 PST
Committed r54263: <http://trac.webkit.org/changeset/54263>