Repro steps: 1. Break Webcore.vcproj 2. Check it in Result: WebCore will never be built, but until there is a clobber, this does not show up as an error. Bots stay green, but tests start failing because they are using old version of WebCore. Expected Result: Bot turns red! Example output: The following error has occurred during XML parsing: File: C:\cygwin\home\buildbot\slave\win-release\build\WebCore\WebCore.vcproj\WebCore.vcproj Line: 24196 Column: 13 Error Message: The name in the end tag of the element must match the element type in the start tag. The file 'C:\cygwin\home\buildbot\slave\win-release\build\WebCore\WebCore.vcproj\WebCore.vcproj' has failed to load. ... ========== Build: 11 succeeded, 0 failed, 6 up-to-date, 0 skipped ========== See http://build.webkit.org/builders/Windows%20Release%20(Build)/builds/9689/steps/compile-webkit/logs/stdio for a full log example.
This would be great to add. I guess it will require a bot-side change? Or maybe there's something we can do to build-webkit to flag it as an error that the bots will recognize?
We could add a simple XML well-formedness check for vcproj and vsprops files. Could do that as a pre-commit hook also/instead.
(In reply to comment #2) > We could add a simple XML well-formedness check for vcproj and vsprops files. > Could do that as a pre-commit hook also/instead. I still think it would be good to do a build-time check, as that will help catch bugs such as specifying the wrong path to a .vsprops file, which a well-formedness check would miss.