When we append a StackCallFrame to the ScriptCallStack, if the calling function is unknown we do not supply the CallFrame with any source id or line number information although this data is available. Instead, an empty source id and line number of 0 is supplied. I propose a patch to add the correct line number and source ID to the callframe. Patch and updates to layout tests to follow.
Created attachment 47829 [details] Proposed patch and updated layout tests.
Comment on attachment 47829 [details] Proposed patch and updated layout tests. > + * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed. > + * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Removed. > + * platform/win/inspector/console-log-before-inspector-open-expected.txt: Removed. Change log doesn't say why you did this. I presume that these platform-specific results were actually just working around the bug?
Thanks for the review! (In reply to comment #2) > (From update of attachment 47829 [details]) > > + * platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed. > > + * platform/mac/inspector/console-log-before-inspector-open-expected.txt: Removed. > > + * platform/win/inspector/console-log-before-inspector-open-expected.txt: Removed. > > Change log doesn't say why you did this. I presume that these platform-specific > results were actually just working around the bug? Precisely - I can update the ChangeLog and land manually, if you like? Thanks, Ben
Comment on attachment 47829 [details] Proposed patch and updated layout tests. Will land manually.
Landed as r54138. Closing bug.