Bug 34292 - V8 implementation of MessageEvent.initMessageEvent() does not set source correctly
Summary: V8 implementation of MessageEvent.initMessageEvent() does not set source corr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 16:50 PST by Andrew Wilson
Modified: 2010-01-29 10:13 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2010-01-28 18:18 PST, Andrew Wilson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2010-01-28 16:50:02 PST
The code to set the source attribute in MessageEvent.initMessageEvent() in the v8 bindings is broken, because it assumes that the passed-in parameter is a wrapped DOMWindow object, when instead it's an object that inherits from DOMWindow via the prototype chain.

This causes fast/events/init-events.html to fail downstream in Chrome.
Comment 1 Andrew Wilson 2010-01-28 18:18:17 PST
Created attachment 47663 [details]
Patch
Comment 2 Adam Barth 2010-01-28 22:01:11 PST
Comment on attachment 47663 [details]
Patch

Nice!  That came out very pretty.
Comment 3 WebKit Commit Bot 2010-01-29 10:13:16 PST
Comment on attachment 47663 [details]
Patch

Clearing flags on attachment: 47663

Committed r54070: <http://trac.webkit.org/changeset/54070>
Comment 4 WebKit Commit Bot 2010-01-29 10:13:21 PST
All reviewed patches have been landed.  Closing bug.