Bug 33584 - [V8] Slow named property lookup on DOMWindow because of missing fast case
Summary: [V8] Slow named property lookup on DOMWindow because of missing fast case
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-13 02:34 PST by Mads Ager
Modified: 2010-01-13 23:35 PST (History)
4 users (show)

See Also:

Attachments
Add fast case checks to V8 named getter on DOMWindow objects. (2.22 KB, patch)
2010-01-13 02:42 PST, Mads Ager 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Ager 2010-01-13 02:34:38 PST 
In the V8 named getter on DOMWindow objects, we always search the DOM using namedItems(propertyName) on the document.  We should check that the document is an HTMLDocument and use fast checks to determine if elements with that name exists before searching the DOM for all occurrences.

See http://crbug.com/32040 for an example where this hits us.
Comment 1 Mads Ager 2010-01-13 02:42:53 PST 
Created attachment 46442 [details]
Add fast case checks to V8 named getter on DOMWindow objects.
Comment 2 Dimitri Glazkov (Google) 2010-01-13 08:27:38 PST 
Comment on attachment 46442 [details]
Add fast case checks to V8 named getter on DOMWindow objects.

looks great!
Comment 3 WebKit Commit Bot 2010-01-13 23:35:08 PST 
Comment on attachment 46442 [details]
Add fast case checks to V8 named getter on DOMWindow objects.

Clearing flags on attachment: 46442

Committed r53241: <http://trac.webkit.org/changeset/53241>
Comment 4 WebKit Commit Bot 2010-01-13 23:35:13 PST 
All reviewed patches have been landed.  Closing bug.