Bug 33433 - Flaky Test: svg/dom/SVGScriptElement/script-set-href.svg
Summary: Flaky Test: svg/dom/SVGScriptElement/script-set-href.svg
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 31107 37560 56790 60118 (view as bug list)
Depends on:
Blocks: 33289
  Show dependency treegraph
 
Reported: 2010-01-09 15:16 PST by Eric Seidel (no email)
Modified: 2017-07-18 08:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.91 KB, patch)
2010-01-13 15:40 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-09 15:16:44 PST
svg/dom/SVGScriptElement/script-set-href.svg failed on Tiger Build Bot

http://build.webkit.org/results/Tiger%20Intel%20Release/r53038%20(7591)/results.html

--- layout-test-results/svg/dom/SVGScriptElement/script-set-href-expected.txt	2010-01-09 00:29:08.000000000 -0800
+++ layout-test-results/svg/dom/SVGScriptElement/script-set-href-actual.txt	2010-01-09 00:29:08.000000000 -0800
@@ -18,4 +18,4 @@
 
 Set after insertion: PASS
 
-Set twice before and once after insertion: PASS
+Set twice before and once after insertion: FAIL

This is the first time I've noticed this failure.  No clue why.

http://trac.webkit.org/browser/trunk/LayoutTests/svg/dom/SVGScriptElement/script-set-href.svg
Written by mitz it seems, reviewed by Mark Rowe.
Comment 1 Eric Seidel (no email) 2010-01-09 15:18:12 PST
    e3.setAttribute("onload", "if (window.layoutTestController) setTimeout('layoutTestController.notifyDone()', 100)"); 

I suspect this test is timing dependent and just flakey in general.
Comment 3 Eric Seidel (no email) 2010-01-13 15:08:07 PST
*** Bug 31107 has been marked as a duplicate of this bug. ***
Comment 5 Eric Seidel (no email) 2010-01-13 15:40:17 PST
Created attachment 46514 [details]
Patch
Comment 6 WebKit Commit Bot 2010-01-13 16:41:30 PST
Comment on attachment 46514 [details]
Patch

Rejecting patch 46514 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11920 test cases.
svg/dom/SVGScriptElement/script-set-href.svg -> failed

Exiting early after 1 failures. 9735 tests run.
204.73s total testing time

9734 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/184832
Comment 7 Eric Seidel (no email) 2010-01-13 16:46:38 PST
Passed for me locally, so I must have done something wrong.  Investigating.
Comment 8 Eric Seidel (no email) 2010-01-13 16:58:09 PST
Looking at the results off the (16 core) bot, looks like my fears came true:
/tmp/layout-test-results/svg/dom/SVGScriptElement/script-set-href-actual.txt

- Self-closing <script> tag: PASS
+ Self-closing <script> tag: FAIL

-  Set before insertion: PASS
+ Set before insertion: FAIL

-  Set after insertion: PASS
+ Set after insertion: FAIL

Looks like the earlier tests hadn't completed by the time the later ones did.  The best way to fix this would be to sign up for the onload events of all of the script tags and only end the test once all of them have fired.
Comment 9 Eric Seidel (no email) 2010-01-14 13:30:02 PST
I am not actively working on this bug.
Comment 10 Eric Seidel (no email) 2010-03-22 17:45:08 PDT
Failed again for the commit-queue just now.

Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12524 test cases.
svg/dom/SVGScriptElement/script-set-href.svg -> failed

Exiting early after 1 failures. 10243 tests run.
246.58s total testing time
Comment 11 Eric Seidel (no email) 2010-03-25 21:34:43 PDT
Failed again on the Leopard Debug bot:
http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r56594%20(11967)/svg/dom/SVGScriptElement/script-set-href-diffs.txt

I've seen it fail for the commit-queue locally as well.
Comment 13 Nikolas Zimmermann 2010-07-09 07:19:25 PDT
Changed component to SVG, so it shows up in my all-svg-bugs search.
Comment 14 Eric Seidel (no email) 2011-05-13 13:48:58 PDT
*** Bug 56790 has been marked as a duplicate of this bug. ***
Comment 15 Eric Seidel (no email) 2011-05-13 13:49:05 PDT
*** Bug 37560 has been marked as a duplicate of this bug. ***
Comment 16 Eric Seidel (no email) 2011-05-13 13:49:11 PDT
*** Bug 60118 has been marked as a duplicate of this bug. ***
Comment 17 Eric Seidel (no email) 2011-05-13 13:50:10 PDT
I suspect this patch could be turned into a final fix with little effort, but I'm not actively working on this (just noticed when cleaning out some old git branches).