Bug 33290 - Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
Summary: Add Chromium bots to the list of "core builders" (builders which stop the com...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33296
  Show dependency treegraph
 
Reported: 2010-01-06 20:16 PST by Eric Seidel (no email)
Modified: 2010-01-07 00:57 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2010-01-07 00:06 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Fix the english in my comment. (4.46 KB, patch)
2010-01-07 00:10 PST, Eric Seidel (no email)
abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-06 20:16:15 PST
Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/buildbot.py#L47

The Chromium bots seem to be pretty stable, so I think it's time that we can depend on them being green.  The "core builders" is the subset of builder which cause the "tree to close" (even though WebKit never really closes the tree like Chromium does).

I'll post a patch to fix this tomorrow unless I hear objections.
Comment 1 Eric Seidel (no email) 2010-01-07 00:06:22 PST
Created attachment 46026 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-07 00:08:09 PST
style-queue ran check-webkit-style on attachment 46026 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-07 00:10:59 PST
Created attachment 46027 [details]
Fix the english in my comment.
Comment 4 WebKit Review Bot 2010-01-07 00:13:29 PST
style-queue ran check-webkit-style on attachment 46027 [details] without any errors.
Comment 5 Eric Seidel (no email) 2010-01-07 00:57:34 PST
Committed r52908: <http://trac.webkit.org/changeset/52908>