Bug 33208 - Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION
Summary: Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-05 07:08 PST by Gabor Loki
Modified: 2010-01-05 07:54 PST (History)
2 users (show)

See Also:


Attachments
Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION (3.49 KB, patch)
2010-01-05 07:09 PST, Gabor Loki
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-01-05 07:08:48 PST
The r52729 breaks ARMAssembler.
We should use WTF_ARM_ARCH_AT_LEAST macro here as well.
Comment 1 Gabor Loki 2010-01-05 07:09:56 PST
Created attachment 45886 [details]
Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION
Comment 2 WebKit Review Bot 2010-01-05 07:12:35 PST
style-queue ran check-webkit-style on attachment 45886 [details] without any errors.
Comment 3 Maciej Stachowiak 2010-01-05 07:38:38 PST
Comment on attachment 45886 [details]
Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION

r=me
Comment 4 Gabor Loki 2010-01-05 07:54:09 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/ARMAssembler.cpp
Sending        JavaScriptCore/assembler/ARMAssembler.h
Transmitting file data ...
Committed revision 52797.