Bug 33086 - [Qt] Enable all HTML5 persistent features for QGVLauncher
Summary: [Qt] Enable all HTML5 persistent features for QGVLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-31 09:40 PST by Laszlo Gombos
Modified: 2010-01-03 17:42 PST (History)
3 users (show)

See Also:


Attachments
proposed patch (1.26 KB, patch)
2009-12-31 09:46 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-12-31 09:40:09 PST
This is done for QtLauncher already, but not for QGVLauncher.
Comment 1 Laszlo Gombos 2009-12-31 09:46:04 PST
Created attachment 45716 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-31 09:49:33 PST
style-queue ran check-webkit-style on attachment 45716 [details] without any errors.
Comment 3 WebKit Commit Bot 2010-01-03 11:26:31 PST
Comment on attachment 45716 [details]
proposed patch

Rejecting patch 45716 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests
Testing 11861 test cases.
fast/canvas/webgl/index-validation-copies-indices.html -> failed

Exiting early after 1 failures. 5000 tests run.
77.72s total testing time

4999 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/160990
Comment 4 Laszlo Gombos 2010-01-03 11:37:40 PST
Comment on attachment 45716 [details]
proposed patch

Landed as r52690.
Comment 5 Eric Seidel (no email) 2010-01-03 17:42:51 PST
Sorry, This patch was a victim of bug 28603.