Bug 32969 - [Qt] Support upload progress events in XMLHttpRequest
Summary: [Qt] Support upload progress events in XMLHttpRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-27 12:56 PST by Jakub Wieczorek
Modified: 2009-12-28 04:03 PST (History)
3 users (show)

See Also:


Attachments
proposed patch (5.35 KB, patch)
2009-12-27 13:01 PST, Jakub Wieczorek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Wieczorek 2009-12-27 12:56:00 PST
To achieve that, the network layer needs to report upload progress to the client if requested (ResourceRequest::reportUploadProgress).
Comment 1 Jakub Wieczorek 2009-12-27 13:01:35 PST
Created attachment 45531 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-27 13:07:29 PST
style-queue ran check-webkit-style on attachment 45531 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-27 19:29:56 PST
Comment on attachment 45531 [details]
proposed patch

Looks right as far as I can tell.
Comment 4 WebKit Commit Bot 2009-12-27 19:39:13 PST
Comment on attachment 45531 [details]
proposed patch

Clearing flags on attachment: 45531

Committed r52590: <http://trac.webkit.org/changeset/52590>
Comment 5 WebKit Commit Bot 2009-12-27 19:39:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Antonio Gomes 2009-12-28 04:03:17 PST
(In reply to comment #3)
> (From update of attachment 45531 [details])
> Looks right as far as I can tell.

lgtm too.

good catch