Bug 32924 - Web Inspector: Implement Edit Inner HTML action.
Summary: Web Inspector: Implement Edit Inner HTML action.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-12-24 14:54 PST by Pavel Feldman
Modified: 2009-12-25 06:24 PST (History)
4 users (show)

See Also:

[PATCH] Proposed change. (8.69 KB, patch)
2009-12-24 15:00 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-24 14:54:33 PST
Popup action with in-place HTML editing.
Comment 1 Pavel Feldman 2009-12-24 15:00:19 PST
Created attachment 45476 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2009-12-24 17:26:31 PST
Comment on attachment 45476 [details]
[PATCH] Proposed change.

> +        }
> +        WebInspector.startEditing(this._htmlEditElement, commit.bind(this), dispose.bind(this), null, true);

I prefer an empty line between lines like this.
Comment 3 Pavel Feldman 2009-12-25 06:24:40 PST
Review comments addressed + I ended up landing "Edit as HTML", not "Edit Inner HTML" version.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/bindings/js/JSInjectedScriptHostCustom.cpp
	M	WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
	M	WebCore/inspector/InjectedScriptHost.cpp
	M	WebCore/inspector/InjectedScriptHost.h
	M	WebCore/inspector/InjectedScriptHost.idl
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/InjectedScriptAccess.js
	M	WebCore/inspector/front-end/InspectorFrontendHostStub.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.js
Committed r52556