Bug 32917 - [Qt] LayoutTests/storage/change-version.html now passes
Summary: [Qt] LayoutTests/storage/change-version.html now passes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-24 05:17 PST by Robert Hogan
Modified: 2009-12-25 01:58 PST (History)
3 users (show)

See Also:


Attachments
Remove from Qt Skipped list (1.86 KB, patch)
2009-12-24 05:21 PST, Robert Hogan
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Updated Patch (1.87 KB, patch)
2009-12-24 15:23 PST, Robert Hogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2009-12-24 05:17:07 PST
Remove LayoutTests/storage/change-version.html from the skipped list as it now passes.
Comment 1 Robert Hogan 2009-12-24 05:21:03 PST
Created attachment 45467 [details]
Remove from Qt Skipped list
Comment 2 WebKit Review Bot 2009-12-24 05:26:20 PST
style-queue ran check-webkit-style on attachment 45467 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-24 11:45:02 PST
Comment on attachment 45467 [details]
Remove from Qt Skipped list

LGTM.
Comment 4 WebKit Commit Bot 2009-12-24 11:45:52 PST
Comment on attachment 45467 [details]
Remove from Qt Skipped list

Rejecting patch 45467 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
7.

https://bugs.webkit.org/show_bug.cgi?id=32917
---
 LayoutTests/ChangeLog           |   13 +++++++++++++
 LayoutTests/platform/qt/Skipped |    3 ---
 2 files changed, 13 insertions(+), 3 deletions(-)


-------------------------------------------------------------------
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/qt/Skipped
Hunk #1 FAILED at 1101.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej

Full output: http://webkit-commit-queue.appspot.com/results/143871
Comment 5 Robert Hogan 2009-12-24 15:23:52 PST
Created attachment 45477 [details]
Updated Patch

Seems Andras moved this to a different place in the skipped list this afternoon. It definitely passes!
Comment 6 WebKit Review Bot 2009-12-24 15:25:14 PST
style-queue ran check-webkit-style on attachment 45477 [details] without any errors.
Comment 7 WebKit Commit Bot 2009-12-24 17:15:12 PST
Comment on attachment 45477 [details]
Updated Patch

Clearing flags on attachment: 45477

Committed r52553: <http://trac.webkit.org/changeset/52553>
Comment 8 WebKit Commit Bot 2009-12-24 17:15:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Andras Becsi 2009-12-25 01:58:34 PST
(In reply to comment #5)
> Created an attachment (id=45477) [details]
> Updated Patch
> 
> Seems Andras moved this to a different place in the skipped list this
> afternoon. It definitely passes!
Sorry for the inconvenience, there was a redundant comment on layoutTestController.notifyDone(), and I've put the test to the place where the other notifyDone() stuff is, but this was obviously not related to the timeout problem.