Bug 32917 – [Qt] LayoutTests/storage/change-version.html now passes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Robert Hogan]

Remove LayoutTests/storage/change-version.html from the skipped list as it now passes.

[Robert Hogan]

Created attachment 45467 [details]
Remove from Qt Skipped list

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45467 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 45467 [details]
Remove from Qt Skipped list

LGTM.

[WebKit Commit Bot]

Comment on attachment 45467 [details]
Remove from Qt Skipped list

Rejecting patch 45467 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1
Last 500 characters of output:
7.

https://bugs.webkit.org/show_bug.cgi?id=32917
---
 LayoutTests/ChangeLog           |   13 +++++++++++++
 LayoutTests/platform/qt/Skipped |    3 ---
 2 files changed, 13 insertions(+), 3 deletions(-)


-------------------------------------------------------------------
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/qt/Skipped
Hunk #1 FAILED at 1101.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej

Full output: http://webkit-commit-queue.appspot.com/results/143871

[Robert Hogan]

Created attachment 45477 [details]
Updated Patch

Seems Andras moved this to a different place in the skipped list this afternoon. It definitely passes!

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45477 [details] without any errors.

[WebKit Commit Bot]

Comment on attachment 45477 [details]
Updated Patch

Clearing flags on attachment: 45477

Committed r52553: <http://trac.webkit.org/changeset/52553>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andras Becsi]

(In reply to comment #5)
> Created an attachment (id=45477) [details]
> Updated Patch
> 
> Seems Andras moved this to a different place in the skipped list this
> afternoon. It definitely passes!
Sorry for the inconvenience, there was a redundant comment on layoutTestController.notifyDone(), and I've put the test to the place where the other notifyDone() stuff is, but this was obviously not related to the timeout problem.