Bug 32400 - Switch remaining cases of string addition to use ropes.
Summary: Switch remaining cases of string addition to use ropes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 16:41 PST by Gavin Barraclough
Modified: 2009-12-11 14:59 PST (History)
2 users (show)

See Also:


Attachments
The patch (10.40 KB, patch)
2009-12-10 16:42 PST, Gavin Barraclough
abarth: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-12-10 16:41:47 PST
Because.
Comment 1 Gavin Barraclough 2009-12-10 16:42:48 PST
Created attachment 44650 [details]
The patch
Comment 2 WebKit Review Bot 2009-12-10 16:44:33 PST
style-queue ran check-webkit-style on attachment 44650 [details] without any errors.
Comment 3 Gavin Barraclough 2009-12-10 18:07:58 PST
Transmitting file data .....
Committed revision 51975.
Comment 4 Adam Barth 2009-12-10 19:43:31 PST
Comment on attachment 44650 [details]
The patch

Rolled out in http://trac.webkit.org/changeset/51978.  This broke fast/js/exception-sequencing-binops.html
Comment 5 Adam Barth 2009-12-10 19:43:48 PST
x
Comment 6 Gavin Barraclough 2009-12-10 21:02:55 PST
Gah, missed that, cheers Adam.
Comment 7 Gavin Barraclough 2009-12-11 14:58:45 PST
Transmitting file data ......
Committed revision 52026.
Comment 8 Gavin Barraclough 2009-12-11 14:59:07 PST
relanded fixed.