Bug 32330 - V8 ScriptState is missing include for DEFINE_STATIC_LOCAL
Summary: V8 ScriptState is missing include for DEFINE_STATIC_LOCAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-09 10:45 PST by Steve Block
Modified: 2009-12-09 15:32 PST (History)
2 users (show)

See Also:


Attachments
Patch 1 for Bug 32330 (985 bytes, patch)
2009-12-09 10:52 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-12-09 10:45:58 PST
V8 ScriptState is missing include for DEFINE_STATIC_LOCAL. This is defined in wtf/StdLibExtras.h.

This causes a build break on Android. It seems that Chromium picks up the include via other feature-dependent header includes.
Comment 1 Steve Block 2009-12-09 10:52:53 PST
Created attachment 44546 [details]
Patch 1 for Bug 32330
Comment 2 WebKit Review Bot 2009-12-09 10:56:17 PST
style-queue ran check-webkit-style on attachment 44546 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-09 13:25:05 PST
Comment on attachment 44546 [details]
Patch 1 for Bug 32330

LGTM too.
Comment 4 WebKit Commit Bot 2009-12-09 15:32:43 PST
Comment on attachment 44546 [details]
Patch 1 for Bug 32330

Clearing flags on attachment: 44546

Committed r51930: <http://trac.webkit.org/changeset/51930>
Comment 5 WebKit Commit Bot 2009-12-09 15:32:48 PST
All reviewed patches have been landed.  Closing bug.