Bug 32275 - Assertions in various functions in DOMHTMLClasses.cpp should be split into two
Summary: Assertions in various functions in DOMHTMLClasses.cpp should be split into two
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: John Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-08 07:55 PST by John Sullivan
Modified: 2009-12-08 08:56 PST (History)
1 user (show)

See Also:

Attachments
Patch to split two-clause assertion into two assertions, in new isAutofilled function and friends (2.31 KB, patch)
2009-12-08 07:55 PST, John Sullivan 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2009-12-08 07:55:06 PST 
This came out of a review comment for bug 32260. The new function DOMHTMLInputElement::isAutofilled has an assertion with two clauses that would be better split into two assertions. This is true for the other functions in this interface as well.
Comment 1 John Sullivan 2009-12-08 07:55:55 PST 
Created attachment 44471 [details]
Patch to split two-clause assertion into two assertions, in new isAutofilled function and friends
Comment 2 WebKit Review Bot 2009-12-08 07:58:11 PST 
style-queue ran check-webkit-style on attachment 44471 [details] without any errors.
Comment 3 John Sullivan 2009-12-08 08:56:08 PST 
Committed in r51857.