RESOLVED FIXED 32083
REGRESSION(51595): commit-queue is throwing exceptions 
https://bugs.webkit.org/show_bug.cgi?id=32083
Summary REGRESSION(51595): commit-queue is throwing exceptions
Eric Seidel (no email)
Reported 2009-12-02 12:45:53 PST
REGRESSION(51595): commit-queue is throwing exceptions More fallout from mixing ints and strings. Adding more unit tests should prevent this trouble in the future.
Attachments
Patch (6.00 KB, patch)
2009-12-02 12:57 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Better patch (9.07 KB, patch)
2009-12-02 14:19 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-12-02 12:57:36 PST
Created attachment 44175 [details] Patch
Eric Seidel (no email)
Comment 2 2009-12-02 13:07:02 PST
Comment on attachment 44175 [details] Patch I'm running the cq with a locally fixed copy, so it's running now and it is possible to cq this patch.
Eric Seidel (no email)
Comment 3 2009-12-02 14:19:20 PST
Created attachment 44185 [details] Better patch
Eric Seidel (no email)
Comment 4 2009-12-02 15:33:49 PST
This is responsible for the death of the style elf as well I'm sure. :(
WebKit Review Bot
Comment 5 2009-12-02 21:12:07 PST
style-queue ran check-webkit-style on attachment 44185 [details] without any errors.
Adam Barth
Comment 6 2009-12-02 21:19:00 PST
*** Bug 32101 has been marked as a duplicate of this bug. ***
Adam Barth
Comment 7 2009-12-02 21:19:39 PST
Comment on attachment 44185 [details] Better patch You win the prize. Your version of this patch >> my version.
WebKit Commit Bot
Comment 8 2009-12-02 21:31:56 PST
Comment on attachment 44185 [details] Better patch Clearing flags on attachment: 44185 Committed r51622: <http://trac.webkit.org/changeset/51622>
WebKit Commit Bot
Comment 9 2009-12-02 21:32:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.