Bug 32015 - Update expectations of css2.1/t1205-c56* for Qt
Summary: Update expectations of css2.1/t1205-c56* for Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-01 03:27 PST by Shinichiro Hamaji
Modified: 2009-12-01 22:32 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (4.88 KB, patch)
2009-12-01 03:28 PST, Shinichiro Hamaji
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-12-01 03:27:14 PST
I've marked some tests as skipped for Qt in Bug 23264. Update the expectations of some of them. Note that other tests will be fixed in Bug 32014 by converting the tests into dumpAsText tests.
Comment 1 Shinichiro Hamaji 2009-12-01 03:28:37 PST
Created attachment 44065 [details]
Patch v1
Comment 2 WebKit Review Bot 2009-12-01 03:31:28 PST
style-queue ran check-webkit-style on attachment 44065 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-01 07:20:25 PST
Comment on attachment 44065 [details]
Patch v1

OK.  Looks sane to me.
Comment 4 Shinichiro Hamaji 2009-12-01 21:50:21 PST
Committed r51586: <http://trac.webkit.org/changeset/51586>
Comment 5 Shinichiro Hamaji 2009-12-01 22:32:06 PST
CCing original authors of these tests.

Darin, I understand your concern. I confirmed that these tests fail if
I reverse-patch the following fixes. Of course, I know this fact
doesn't show I didn't lose any information from the original test,
though. Please let me know if there are some more information I can
tell. Or, if you feel you'd never be confident, please let me know and
I'll just update the expectations of these tests.

https://bugs.webkit.org/show_bug.cgi?id=13887
https://bugs.webkit.org/show_bug.cgi?id=12746
Comment 6 Shinichiro Hamaji 2009-12-01 22:32:57 PST
Oops, I posted the comment on wrong bug... Please just ignore.