Bug 31995 - [bzt] Generate pass messages for style-queue
Summary: [bzt] Generate pass messages for style-queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-30 12:58 PST by Adam Barth
Modified: 2009-11-30 16:07 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.24 KB, patch)
2009-11-30 13:01 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-11-30 12:58:17 PST
As requested on webkit-dev.
Comment 1 Adam Barth 2009-11-30 13:01:02 PST
Created attachment 44037 [details]
Patch
Comment 2 Adam Barth 2009-11-30 13:05:27 PST
style-queue ran check-webkit-style on attachment 44037 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-11-30 15:53:04 PST
Comment on attachment 44037 [details]
Patch

Where is the unit test? :)

Otherwise LGTM...  Would really like a test though. :)
Comment 4 Adam Barth 2009-11-30 15:57:53 PST
Comment on attachment 44037 [details]
Patch

Yeah, testing is next on my list.  I went a little hack-and-slash at the end to get the bot to a working state.
Comment 5 WebKit Commit Bot 2009-11-30 16:07:49 PST
Comment on attachment 44037 [details]
Patch

Clearing flags on attachment: 44037

Committed r51518: <http://trac.webkit.org/changeset/51518>
Comment 6 WebKit Commit Bot 2009-11-30 16:07:54 PST
All reviewed patches have been landed.  Closing bug.