Bug 31973 - webkit-patch should check the date in the ChangeLog entry before landing
Summary: webkit-patch should check the date in the ChangeLog entry before landing
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-29 18:39 PST by Daniel Bates
Modified: 2010-01-19 16:52 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-11-29 18:39:41 PST
Bugzilla-tool should confirm that the date in the ChangeLog entry matches the current date when you land a patch. In particular, when you land-diff.

Unfortunately, I realized this the hard way. When I committed change set r51468 <http://trac.webkit.org/changeset/51468>, I noticed the date was from yesterday (11/28). Even though, bugzilla-tool was smart enough to fill in the reviewer, it didn't check the date :-(. Hence, I had to manually commit a fix in change set r51469 <http://trac.webkit.org/changeset/51469>.
Comment 1 Eric Seidel (no email) 2010-01-19 16:52:45 PST
This is yet another variant of the same "if you screw up the change log webkit-patch will happily land it, and even screw up your commit-message for you too!" bug.  This is very common for git users to hit due to git svn rebase doing the wrong merge thing. :(