Bug 31945 - [bzt] style-queue should report style errors to bugzilla
Summary: [bzt] style-queue should report style errors to bugzilla
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-27 17:36 PST by Adam Barth
Modified: 2009-11-28 16:17 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.54 KB, patch)
2009-11-27 17:39 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-11-27 17:36:38 PST
style-queue should report style errors to bugzilla
Comment 1 Adam Barth 2009-11-27 17:39:03 PST
Created attachment 43976 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-11-28 09:51:56 PST
Comment on attachment 43976 [details]
Patch

We should make args always be a list.  I don't like having to handle both cases.
Comment 3 Adam Barth 2009-11-28 10:17:07 PST
Can we do that in a follow up patch?  I agree we should do that, but shaving that yak isn't required for this patch.
Comment 4 Eric Seidel (no email) 2009-11-28 11:22:48 PST
Comment on attachment 43976 [details]
Patch

OK.  But please at least add a FIXME next to the regexp one, since it shouldn't be needed.
Comment 5 Adam Barth 2009-11-28 16:17:41 PST
Committed r51462: <http://trac.webkit.org/changeset/51462>