Bug 31663 - Some tests in fast/css-generated-content can be dumpAsText test
Summary: Some tests in fast/css-generated-content can be dumpAsText test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-19 00:45 PST by Shinichiro Hamaji
Modified: 2009-11-19 04:33 PST (History)
0 users

See Also:


Attachments
Patch v1 (64.15 KB, patch)
2009-11-19 00:46 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-11-19 00:45:30 PST
These three tests are checking if the webkit crashes:

- absolute-position-inside-inline
- positioned-background-hit-test-crash
- spellingToolTip-assert

The results of the following test is stored using innerHTML and there are nothing we should see by image.

- hit-test-generated-content
Comment 1 Shinichiro Hamaji 2009-11-19 00:46:32 PST
Created attachment 43492 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-11-19 01:04:53 PST
Comment on attachment 43492 [details]
Patch v1

OK.  LGTM.

Sooooo glad to get rid of more needless rendering tree dumps!
Comment 3 Shinichiro Hamaji 2009-11-19 04:32:57 PST
Comment on attachment 43492 [details]
Patch v1

Clearing flags on attachment: 43492

Committed r51181: <http://trac.webkit.org/changeset/51181>
Comment 4 Shinichiro Hamaji 2009-11-19 04:33:07 PST
All reviewed patches have been landed.  Closing bug.