RESOLVED FIXED 31592
commit-queue is failing to set reviewer in ChangeLogs 
https://bugs.webkit.org/show_bug.cgi?id=31592
Summary commit-queue is failing to set reviewer in ChangeLogs
Eric Seidel (no email)
Reported 2009-11-17 11:15:26 PST
commit-queue is failing to set reviewer in ChangeLogs https://bugs.webkit.org/show_bug.cgi?id=31504#c6 bugzilla-tool apply-patches 31504 still works as expected. bugzilla-tool apply-attachment 43221 [details] however does not correctly set the reviewer. I expect those symptoms are related.
Attachments
Patch (2.85 KB, patch)
2009-11-17 11:50 PST, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-11-17 11:50:13 PST
Created attachment 43372 [details] Patch
Eric Seidel (no email)
Comment 2 2009-11-17 11:53:36 PST
I've filed bug 31594 about some of the further cleanup needed here.
Darin Adler
Comment 3 2009-11-17 11:55:53 PST
Comment on attachment 43372 [details] Patch rs=me
Eric Seidel (no email)
Comment 4 2009-11-17 11:56:59 PST
Thank you Darin!
Eric Seidel (no email)
Comment 5 2009-11-17 11:58:04 PST
For those playing along at home, this was a regression caused by bug 31546 and bug 31548.
Eric Seidel (no email)
Comment 6 2009-11-17 12:11:43 PST
Committed r51085: <http://trac.webkit.org/changeset/51085>
Adam Barth
Comment 7 2009-11-18 08:18:31 PST
Obligatory test nag.
Eric Seidel (no email)
Comment 8 2009-11-18 12:12:13 PST
Oh true. Thank you Adam. I'll add one shortly on bug 31632.
Note You need to log in before you can comment on or make changes to this bug.