Bug 31592 - commit-queue is failing to set reviewer in ChangeLogs
Summary: commit-queue is failing to set reviewer in ChangeLogs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 31632
  Show dependency tree / graph
 
Reported: 2009-11-17 11:15 PST by Eric Seidel (no email)
Modified: 2009-11-18 12:12 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.85 KB, patch)
2009-11-17 11:50 PST, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-17 11:15:26 PST 
commit-queue is failing to set reviewer in ChangeLogs

https://bugs.webkit.org/show_bug.cgi?id=31504#c6

bugzilla-tool apply-patches 31504

still works as expected.

bugzilla-tool apply-attachment 43221 [details]

however does not correctly set the reviewer.

I expect those symptoms are related.
Comment 1 Eric Seidel (no email) 2009-11-17 11:50:13 PST 
Created attachment 43372 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-11-17 11:53:36 PST 
I've filed bug 31594 about some of the further cleanup needed here.
Comment 3 Darin Adler 2009-11-17 11:55:53 PST 
Comment on attachment 43372 [details]
Patch

rs=me
Comment 4 Eric Seidel (no email) 2009-11-17 11:56:59 PST 
Thank you Darin!
Comment 5 Eric Seidel (no email) 2009-11-17 11:58:04 PST 
For those playing along at home, this was a regression caused by bug 31546 and bug 31548.
Comment 6 Eric Seidel (no email) 2009-11-17 12:11:43 PST 
Committed r51085: <http://trac.webkit.org/changeset/51085>
Comment 7 Adam Barth 2009-11-18 08:18:31 PST 
Obligatory test nag.
Comment 8 Eric Seidel (no email) 2009-11-18 12:12:13 PST 
Oh true.  Thank you Adam.  I'll add one shortly on bug 31632.