Bug 31350 - Allow custom memory allocation control for the part of page directory in WebCore
Summary: Allow custom memory allocation control for the part of page directory in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-11 05:37 PST by Zoltan Horvath
Modified: 2009-11-11 09:08 PST (History)
0 users

See Also:


Attachments
proposed patch (6.76 KB, patch)
2009-11-11 05:39 PST, Zoltan Horvath
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-11-11 05:37:59 PST
Inherits the following classes from Noncopyable because these are instantiated by 'new' and these are no need to be copyable:

class DragController         - instantiated at: WebCore/page/Page.cpp:107
class FocusController        - instantiated at: WebCore/page/Page.cpp:109
class Settings               - instantiated at: WebCore/page/Page.cpp:116
class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222

Inherits PropertyWrapperBase class from Noncopyable because (its child class) PropertyWrapper is instantiated by 'new' in WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
Comment 1 Zoltan Horvath 2009-11-11 05:39:56 PST
Created attachment 42956 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2009-11-11 08:39:41 PST
Comment on attachment 42956 [details]
proposed patch

Looks sane.
Comment 3 Zoltan Horvath 2009-11-11 09:08:36 PST
Landed in 50810.
http://trac.webkit.org/changeset/50810