Bug 31333 - WebKitGTK+ 1.1.15.3 tarball build failed
Summary: WebKitGTK+ 1.1.15.3 tarball build failed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 23:20 PST by Yan Li
Modified: 2010-04-07 11:23 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yan Li 2009-11-10 23:20:36 PST
WebKitGTK+ 1.1.15.3 release tarball at http://webkitgtk.org/ failed to build, since WebCore::EventTarget::addEventListener and WebCore::EventTarget::removeEventListener are pure virtual functions there, without any implementation.

Build errors:
./WebCore/page/DOMWindow.h: In static member function ‘static WTF::PassRefPtr<WebCore::DOMWindow> WebCore::DOMWindow::create(WebCore::Frame*)’:
./WebCore/page/DOMWindow.h:77: error: cannot allocate an object of abstract type ‘WebCore::DOMWindow’
./WebCore/page/DOMWindow.h:75: note:   because the following virtual functions are pure within ‘WebCore::DOMWindow’:
./WebCore/dom/EventTarget.h:93: note: 	virtual void WebCore::EventTarget::addEventListener(const WebCore::AtomicString&, WTF::PassRefPtr<WebCore::EventListener>, bool)
./WebCore/dom/EventTarget.h:94: note: 	virtual void WebCore::EventTarget::removeEventListener(const WebCore::AtomicString&, WebCore::EventListener*, bool)
(lots of similar errors omitted)

Build configuration:
 Enable debugging (slow)                                  : no
 Enable GCC build optimization                            : yes
 Code coverage support                                    : no
 Unicode backend                                          : icu
 Font backend                                             : freetype
 Optimized memory allocator                               : yes
Features:
 3D Transforms                                            : no
 JIT compilation                                          : no
 Dashboard support                                        : yes
 Filters support                                          : no
 Geolocation support                                      : no
 JavaScript debugger/profiler support                     : yes
 HTML5 offline web applications support                   : yes
 HTML5 channel messaging support                          : yes
 HTML5 client-side session and persistent storage support : yes
 HTML5 client-side database storage support               : yes
 HTML5 ruby support                                       : yes
 HTML5 server-sent events support                         : yes
 HTML5 video element support                              : yes
 Icon database support                                    : yes
 SharedWorkers support                                    : no
 SVG support                                              : yes
 SVG animation support                                    : yes
 SVG fonts support                                        : yes
 SVG foreign object support                               : yes
 SVG as image support                                     : yes
 SVG use element support                                  : yes
 WML support                                              : no
 Web Sockets support                                      : no
 Web Workers support                                      : yes
 XPATH support                                            : yes
 XSLT support                                             : yes
GTK+ configuration:
 GDK target                                               : x11
 Hildon UI extensions                                     : no

Tested on Moblin Trunk.

Please release a new tarball since this release doesn't build at all.
Comment 1 Yan Li 2009-11-10 23:23:32 PST
Seems commit 48701 changed them to virtual and added implementations.
Comment 2 Julien Chaffraix 2010-04-06 21:28:02 PDT
The current stable version of WebKitGTK+ is 1.2.0. It seems like this bug is not relevant anymore. Should it be closed?
Comment 3 Gustavo Noronha (kov) 2010-04-07 11:23:17 PDT
I think so. Please reopen if you can reproduce with 1.2.0.