Bug 31323 - Fix a few compiler warnings
Summary: Fix a few compiler warnings
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-10 15:38 PST by Laszlo Gombos
Modified: 2009-11-11 06:45 PST (History)
1 user (show)

See Also:

proposed patch (2.87 KB, patch)
2009-11-10 16:02 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-10 15:38:13 PST
QtWebKit built on Linux using GCC 4.4 reports the following compiler warnings:

WebCore/editing/htmlediting.cpp: In function bool WebCore::isRenderedAsNonInlineTableImageOrHR(const WebCore::Node*):
WebCore/editing/htmlediting.cpp:1087: warning: suggest parentheses around && within ||

WebKit/qt/tests/qwebframe/tst_qwebframe.cpp: In member function virtual QNetworkReply* FakeNetworkManager::createRequest(QNetworkAccessManager::Operation, const QNetworkRequest&, QIODevice*):
WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2241: warning: suggest explicit braces to avoid ambiguous else
Comment 1 Laszlo Gombos 2009-11-10 16:02:44 PST
Created attachment 42905 [details]
proposed patch
Comment 2 WebKit Commit Bot 2009-11-11 06:45:47 PST
Comment on attachment 42905 [details]
proposed patch

Clearing flags on attachment: 42905

Committed r50806: <http://trac.webkit.org/changeset/50806>
Comment 3 WebKit Commit Bot 2009-11-11 06:45:52 PST
All reviewed patches have been landed.  Closing bug.