Bug 31310 - Fix back/forwards cache with JSC isolated worlds.
Summary: Fix back/forwards cache with JSC isolated worlds.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 13:39 PST by Gavin Barraclough
Modified: 2009-11-10 14:22 PST (History)
0 users

See Also:


Attachments
The patch (9.02 KB, patch)
2009-11-10 13:54 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-11-10 13:39:57 PST
<rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
Comment 1 Gavin Barraclough 2009-11-10 13:54:41 PST
Created attachment 42891 [details]
The patch
Comment 2 Geoffrey Garen 2009-11-10 14:18:24 PST
Comment on attachment 42891 [details]
The patch

r=me

I think it would be good to move away from weak pointers to worlds in the future. Objects that point to worlds should just ref them.
Comment 3 Gavin Barraclough 2009-11-10 14:22:20 PST
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/js/JSDOMBinding.cpp
Sending        WebCore/bindings/js/JSDOMBinding.h
Sending        WebCore/bindings/js/ScriptCachedFrameData.cpp
Sending        WebCore/bindings/js/ScriptCachedFrameData.h
Sending        WebCore/bindings/js/ScriptController.h
Transmitting file data ......
Committed revision 50767.