31289 – rename counter to makeCounterNode in RenderCounter.cpp

Bug 31289 - rename counter to makeCounterNode in RenderCounter.cpp

Summary: rename counter to makeCounterNode in RenderCounter.cpp

Attachments
Patch v1 (2.61 KB, patch) 2009-11-10 04:07 PST, Shinichiro Hamaji	no flags	Details \| Formatted Diff \| Diff
Patch v2 (4.68 KB, patch) 2009-11-17 01:41 PST, Shinichiro Hamaji	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Shinichiro Hamaji 2009-11-10 04:06:31 PST

As suggested in Bug 30505, the function name "counter" isn't good as this creates a counter as a side-effect.

Comment 1 Shinichiro Hamaji 2009-11-10 04:07:30 PST

Created attachment 42857 [details]
Patch v1

Comment 2 Shinichiro Hamaji 2009-11-10 19:16:38 PST

Comment on attachment 42857 [details]
Patch v1

Clearing flags on attachment: 42857

Committed r50787: <http://trac.webkit.org/changeset/50787>

Comment 3 Shinichiro Hamaji 2009-11-10 19:16:44 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Shinichiro Hamaji 2009-11-17 01:41:45 PST

Created attachment 43349 [details]
Patch v2

Comment 5 Dimitri Glazkov (Google) 2009-11-17 08:27:23 PST

Whoops, wrong bug? :) You should probably repost the patch you have here as a new issue.

Comment 6 Darin Adler 2009-11-17 09:43:18 PST

Comment on attachment 43349 [details]
Patch v2

Clearing review flag since this was attached to the wrong bug.