RESOLVED FIXED31289
rename counter to makeCounterNode in RenderCounter.cpp 
https://bugs.webkit.org/show_bug.cgi?id=31289
Summary rename counter to makeCounterNode in RenderCounter.cpp
Shinichiro Hamaji
Reported 2009-11-10 04:06:31 PST
As suggested in Bug 30505, the function name "counter" isn't good as this creates a counter as a side-effect.
Attachments
Patch v1 (2.61 KB, patch)
2009-11-10 04:07 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Patch v2 (4.68 KB, patch)
2009-11-17 01:41 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-11-10 04:07:30 PST
Created attachment 42857 [details] Patch v1
Shinichiro Hamaji
Comment 2 2009-11-10 19:16:38 PST
Comment on attachment 42857 [details] Patch v1 Clearing flags on attachment: 42857 Committed r50787: <http://trac.webkit.org/changeset/50787>
Shinichiro Hamaji
Comment 3 2009-11-10 19:16:44 PST
All reviewed patches have been landed. Closing bug.
Shinichiro Hamaji
Comment 4 2009-11-17 01:41:45 PST
Created attachment 43349 [details] Patch v2
Dimitri Glazkov (Google)
Comment 5 2009-11-17 08:27:23 PST
Whoops, wrong bug? :) You should probably repost the patch you have here as a new issue.
Darin Adler
Comment 6 2009-11-17 09:43:18 PST
Comment on attachment 43349 [details] Patch v2 Clearing review flag since this was attached to the wrong bug.
Note You need to log in before you can comment on or make changes to this bug.