RESOLVED FIXED310082
[libpas] PAS_ASSERT should always use brk #0xc471 instead of #0x1 
https://bugs.webkit.org/show_bug.cgi?id=310082
Summary [libpas] PAS_ASSERT should always use brk #0xc471 instead of #0x1
Marcus Plutowski
Reported 2026-03-16 23:05:48 PDT
rdar://172722059 When libpas calls PAS_ASSERT with more than one argument, the __LINE__ and all arguments except the first (the condition) are stored in registers for our perusal in crash-dumps, and then we execute `brk #0xc471` to crash the program. But if it’s just one argument, then we instead do `__builtin_trap()` and rely on it being lowered to `__builtin_trap()` i.e. `brk #0x1`. Which is a bad idea for a variety of reasons.
Attachments
Add attachment proposed patch, testcase, etc.
Marcus Plutowski
Comment 1 2026-03-16 23:54:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/60748
EWS
Comment 2 2026-03-20 22:09:15 PDT
Committed 309669@main (7b43a563bdda): <https://commits.webkit.org/309669@main> Reviewed commits have been landed. Closing PR #60748 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.