RESOLVED FIXED30968
Fix windows expected results affected by patch http://trac.webkit.org/changeset/50315 
https://bugs.webkit.org/show_bug.cgi?id=30968
Summary Fix windows expected results affected by patch http://trac.webkit.org/changes...
Victor Wang
Reported 2009-10-30 16:01:49 PDT
Patch "http://trac.webkit.org/changeset/50315" makes links mouse focusable only on GTK and QT, so Windows has same behavior as mac. Need to remove win specific expected results for tests related to this patch: fast/events/click-focus-anchor.html fast/inline/dirtyLinesForInline.html
Attachments
Proposed Patch (3.46 KB, patch)
2009-10-30 16:13 PDT, Victor Wang 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2009-10-30 16:13:51 PDT
Created attachment 42242 [details] Proposed Patch
Eric Seidel (no email)
Comment 2 2009-11-01 18:24:15 PST
Comment on attachment 42242 [details] Proposed Patch OK. I dont' think Victor is a committer yet, so marking cq+ too.
WebKit Commit Bot
Comment 3 2009-11-01 19:12:10 PST
Comment on attachment 42242 [details] Proposed Patch Rejecting patch 42242 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 2 Last 500 characters of output: eded at 1 with fuzz 3. patching file LayoutTests/platform/win/fast/events/click-focus-anchor-expected.txt rm 'LayoutTests/platform/win/fast/events/click-focus-anchor-expected.txt' patching file LayoutTests/platform/win/fast/inline/dirtyLinesForInline-expected.txt rm 'LayoutTests/platform/win/fast/inline/dirtyLinesForInline-expected.txt' Could not open 'LayoutTests/platform/win/fast/inline' to list files: 0 at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 283, <> line 75.
Eric Seidel (no email)
Comment 4 2009-11-01 19:41:56 PST
I'm not sure what's up here. svn-apply does have known issues with git binary deletions, but that shouldn't be the problem here. bug 28456.
Victor Wang
Comment 5 2009-11-03 10:40:47 PST
Patch landed: Changed by: japhet@chromium.org Changed at: Tue 03 Nov 2009 09:49:24 Branch: trunk Revision: 50461
Note You need to log in before you can comment on or make changes to this bug.