Bug 30671 - [Qt] NPAPI compilation failure in Symbian
Summary: [Qt] NPAPI compilation failure in Symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Emulator S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 27065
  Show dependency tree / graph
 
Reported: 2009-10-22 04:52 PDT by Janne Koskinen
Modified: 2009-10-23 12:23 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix for npapi.h (1.73 KB, patch)
2009-10-22 06:53 PDT, Janne Koskinen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Janne Koskinen 2009-10-22 04:52:12 PDT 
npapi.h will undef NULL in Symbian emulator environment
causing the compiler to fail when including QRegion.
Comment 1 Janne Koskinen 2009-10-22 06:53:06 PDT 
Created attachment 41657 [details]
proposed fix for npapi.h
Comment 2 Tor Arne Vestbø 2009-10-23 06:22:39 PDT 
Comment on attachment 41657 [details]
proposed fix for npapi.h

Thanks!
Comment 3 WebKit Commit Bot 2009-10-23 06:30:29 PDT 
Comment on attachment 41657 [details]
proposed fix for npapi.h

Rejecting patch 41657 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11506 test cases.
fast/media/mq-transform-02.html -> failed

Exiting early after 1 failures. 7441 tests run.
133.66s total testing time

7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output
Comment 4 Yael 2009-10-23 07:10:24 PDT 
Is anyone still compiling NPAPI with CodeWarrior? 
Perhaps the code inside "#ifdef __MWERKS__"  could just be removed ?
Comment 5 Eric Seidel (no email) 2009-10-23 12:02:08 PDT 
Comment on attachment 41657 [details]
proposed fix for npapi.h

Sorry about the commit-queue trouble.  Should work fine now.
Comment 6 WebKit Commit Bot 2009-10-23 12:23:08 PDT 
Comment on attachment 41657 [details]
proposed fix for npapi.h

Clearing flags on attachment: 41657

Committed r49987: <http://trac.webkit.org/changeset/49987>
Comment 7 WebKit Commit Bot 2009-10-23 12:23:13 PDT 
All reviewed patches have been landed.  Closing bug.