Bug 30662 - [Qt] Plugins: Make manual tests reference local test.swf instead of youtube
Summary: [Qt] Plugins: Make manual tests reference local test.swf instead of youtube
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on: 30503
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-21 22:28 PDT by Girish Ramakrishnan
Modified: 2009-10-23 05:04 PDT (History)
2 users (show)

See Also:


Attachments
Use test.swf instead of youtube as src (17.21 KB, patch)
2009-10-21 22:33 PDT, Girish Ramakrishnan
no flags Details | Formatted Diff | Diff
Use test.swf instead of youtube as src (2) (17.02 KB, patch)
2009-10-21 22:37 PDT, Girish Ramakrishnan
zecke: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2009-10-21 22:28:00 PDT
Apart from the worry that the youtube video might link disappear someday, it's nice to able to work offline.
Comment 1 Girish Ramakrishnan 2009-10-21 22:33:27 PDT
Created attachment 41637 [details]
Use test.swf instead of youtube as src
Comment 2 Girish Ramakrishnan 2009-10-21 22:37:39 PDT
Created attachment 41638 [details]
Use test.swf instead of youtube as src  (2)

#@$! Sorry, wrong patch file last time.
Comment 3 Holger Freyther 2009-10-22 04:55:31 PDT
Comment on attachment 41638 [details]
Use test.swf instead of youtube as src  (2)

Okay, the next change would be to consolidate the usage of this swf file. :)
Comment 4 WebKit Commit Bot 2009-10-22 04:58:31 PDT
Comment on attachment 41638 [details]
Use test.swf instead of youtube as src  (2)

Rejecting patch 41638 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Holger Freyther', '--force']" exit_code: 2
Last 500 characters of output:
|    3 ++-
 5 files changed, 24 insertions(+), 3 deletions(-)
 create mode 100644 WebCore/manual-tests/plugins/test.swf


-------------------------------------------------------------------
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patch: **** Only garbage was found in the patch input.
patching file WebCore/manual-tests/plugins/windowed.html
patching file WebCore/manual-tests/plugins/windowless.html
patching file WebCore/manual-tests/qt/plugin-sibling-frame-include.html
Comment 5 Girish Ramakrishnan 2009-10-22 10:06:14 PDT
Holger, I have pushed changes here - http://gitorious.org/~girish/qtwebkit/girishs-clone/commits/from_youtube_to_test.swf_30662

Maybe we should try to land it manually?
Comment 6 Eric Seidel (no email) 2009-10-22 10:32:45 PDT
I expect this is just another case of bug 26830.
Comment 7 Holger Freyther 2009-10-23 05:04:10 PDT
Landed in r49973.